-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated drivers #1013
Remove outdated drivers #1013
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #1013 +/- ##
==========================================
+ Coverage 42.76% 51.58% +8.81%
==========================================
Files 80 58 -22
Lines 5654 2749 -2905
==========================================
- Hits 2418 1418 -1000
+ Misses 3236 1331 -1905
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@alecandido I just remembered that I forgot to also update docs (drop references to the removed drivers). Do you think I also need to drop the dependencies in pyproject.toml? |
Docs would be good, but take into account that the docs may also be partially broken, and definitely outdated. Concerning |
I dropped most references from the docs, excluding in We can refer to the diff of this PR to put back some of the removed stuff as we are reintroducing the drivers. |
As discussed with @alecandido, this is dropping the following drivers:
QM and R&S are being "tested" using qw11qD and will be included in the first 0.2 release. Bluefors and EraSynth are not tested, but there is a chance they are unaffected so I left them. ZI was partially updated in #885, but for sure it is not working anymore as there were several breaking changes since then. I left it for now but we could even remove.
I also removed the associated tests, including the ones for ZI, as they are broken and there is no time to fix now. We can re-introduce tests at will while updating the corresponding driver.