Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated drivers #1013

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Remove outdated drivers #1013

merged 4 commits into from
Aug 28, 2024

Conversation

stavros11
Copy link
Member

As discussed with @alecandido, this is dropping the following drivers:

  • emulator,
  • qblox,
  • RFSoC,
  • IcarusQ.

QM and R&S are being "tested" using qw11qD and will be included in the first 0.2 release. Bluefors and EraSynth are not tested, but there is a chance they are unaffected so I left them. ZI was partially updated in #885, but for sure it is not working anymore as there were several breaking changes since then. I left it for now but we could even remove.

I also removed the associated tests, including the ones for ZI, as they are broken and there is no time to fix now. We can re-introduce tests at will while updating the corresponding driver.

@stavros11 stavros11 requested a review from alecandido August 28, 2024 14:35
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.58%. Comparing base (bd4e2cf) to head (3cbccee).
Report is 5 commits behind head on 0.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              0.2    #1013      +/-   ##
==========================================
+ Coverage   42.76%   51.58%   +8.81%     
==========================================
  Files          80       58      -22     
  Lines        5654     2749    -2905     
==========================================
- Hits         2418     1418    -1000     
+ Misses       3236     1331    -1905     
Flag Coverage Δ
unittests 51.58% <ø> (+8.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stavros11 stavros11 changed the title Rm drivers Remove outdated drivers Aug 28, 2024
@stavros11
Copy link
Member Author

@alecandido I just remembered that I forgot to also update docs (drop references to the removed drivers). Do you think I also need to drop the dependencies in pyproject.toml?

@stavros11 stavros11 added this to the Qibolab 0.2.0 milestone Aug 28, 2024
@alecandido
Copy link
Member

@alecandido I just remembered that I forgot to also update docs (drop references to the removed drivers). Do you think I also need to drop the dependencies in pyproject.toml?

Docs would be good, but take into account that the docs may also be partially broken, and definitely outdated.
That's why we have #973

Concerning pyproject.toml, I would not touch it. We want to add back all drivers, and it is slightly good to preserve the dependencies, and ensure we're still compatible (just because they are optional, I'd not be so convinced otherwise).

@stavros11
Copy link
Member Author

I dropped most references from the docs, excluding in installation.rst which in principle is still valid since we are not touching pyproject.toml. I also dropped all examples/ since they are very outdated (some even with respect to the current 0.1 branch).

We can refer to the diff of this PR to put back some of the removed stuff as we are reintroducing the drivers.

@stavros11 stavros11 merged commit c180cd9 into 0.2 Aug 28, 2024
28 checks passed
@stavros11 stavros11 deleted the rm-drivers branch August 28, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants